ITEP-90209: tracked object contains re-id state and object id chain#1302
Draft
saratpoluri wants to merge 11 commits intomainfrom
Draft
ITEP-90209: tracked object contains re-id state and object id chain#1302saratpoluri wants to merge 11 commits intomainfrom
saratpoluri wants to merge 11 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Scene Controller’s tracked-object output to carry explicit ReID status and an object-ID history chain (for post-mortem stitching/analysis), and updates multiple service “Agents” guides plus repository Copilot instructions to reflect current build/test workflows.
Changes:
- Add
ReidState+previous_ids_chaintracking onMovingObject, and serialize these fields in detection outputs. - Update UUID assignment / similarity-query flow to set ReID state and record ID-chain transitions.
- Refresh build/test instructions across service
Agents.mddocs and.github/copilot-instructions.md.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
controller/src/controller/moving_object.py |
Introduces ReidState, ID-chain recording helpers, and new per-object fields. |
controller/src/controller/uuid_manager.py |
Updates similarity-query / ID assignment to set ReID state and record ID changes. |
controller/src/controller/detections_builder.py |
Serializes reid_state and previous_ids_chain into object dictionaries. |
controller/Agents.md |
Updates controller build/test instructions (currently has Markdown fence issues). |
mapping/Agents.md |
Updates mapping build/test instructions (wording vs actual Make targets mismatch). |
manager/Agents.md |
Updates manager build/test instructions (wording vs actual Make targets mismatch). |
autocalibration/Agents.md |
Updates autocalibration build/test instructions (wording vs actual Make targets mismatch). |
cluster_analytics/Agents.md |
Updates cluster_analytics build/test instructions (wording vs actual Make targets mismatch). |
.github/copilot-instructions.md |
Updates repo-wide guidance for build/test prerequisites and test targets. |
saratpoluri
requested review from
a team,
Irakus,
MikolajKasprzak,
daddo-intel,
dmytroye,
ltalarcz,
sarthakdeva-intel,
sbelhaik and
tdorauintc
as code owners
saratpoluri
force-pushed
the
feature/object-reided
branch
from
d5947ae to
e20595a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Provide a clear summary of the changes and the context behind them. Describe what was changed, why it was needed, and how the changes address the issue or add value.
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: